docs: add ADR for locking the analyzer Roslyn floor#83
Merged
Conversation
Persist the architecture decision behind the analyzer's Roslyn floor as ADR 0001, so the rationale a future maintainer needs (why the floor exists, why it is guarded four ways, and how to raise it) survives outside commit history and inline comments. The document is verified against the current tree. Placed under maintainers/adr/ — the maintainer/operational documentation home, deliberately separate from doc/ (the library's user documentation). English only: an ADR is an internal decision record, not user-facing library docs, so it is not part of the French translation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Persist the architecture decision behind the analyzer's Roslyn floor as ADR 0001, so the rationale a future maintainer needs (why the floor exists, why it is guarded four ways, and how to raise it) survives outside commit history and inline comments.
Type of change
Changes
maintainers/adr/0001-lock-the-analyzer-roslyn-floor.md(new): records the load contract (CS8032/AD0001), the single source of truth (RoslynFloorVersion), the four guards (the pin, theRoslynFloorTestsunit test, the floor-check CI job, the Dependabot ignore), the floor-check job's NuGet subtleties, the consequences, and a step-by-step "how to raise the floor". Placed undermaintainers/(maintainer/operational docs), deliberately separate fromdoc/(the library's user documentation).Testing
dotnet build FirstClassErrors.slndotnet test FirstClassErrors.slnFirstClassErrors.Analyzers.UnitTests)Not applicable: documentation-only change, no code touched. The document's factual claims were verified against the current tree (floor
4.8.0, the pin, the four guards, the floor-check job).Documentation
doc/user documentation or its French translation.Related issues
🤖 Generated with Claude Code
https://claude.ai/code/session_01AbXi2ZEaUFeFWodNxdY6Zk
Generated by Claude Code